Fix thread-safety in GlobalKaleidoServer: replace shared return queue with per-task Futures#431
Open
talleibman wants to merge 1 commit intoplotly:masterfrom
Open
Conversation
Avoids potential result/caller mismatch when multiple threads call call_function concurrently—each caller now blocks on its own Future.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We hit an issue in production where concurrent call_function calls occasionally returned each other's results. The shared _return_queue has no guarantee that the caller who put the task gets the matching result back.
Fix: each Task now carries its own concurrent.futures.Future. The worker sets the result/exception directly on it, and the caller blocks on future.result().
Tested locally with Python 3.8 and 3.14.
Thanks for the review!