fix(shared): use border box for element resize#2419
Open
apples-kksk wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ef91275 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested\nFixes #2288\n\n## Implemented\n- Observe elements with { box: "border-box" } when supported.\n- Prefer ResizeObserverEntry.borderBoxSize for reported dimensions.\n- Preserve fallback behavior for older browsers by falling back to contentRect and to plain observe(target) when observe options are unsupported.\n- Map inlineSize/blockSize for vertical and sideways writing modes.\n- Added unit coverage for border-box sizing, vertical writing mode mapping, sideways writing mode mapping, contentRect fallback, unsupported observe options fallback, and non-TypeError observe failures.\n\n## Not covered\nNo changes to window resize handling.\n\n## Validated\n- git diff --check\n\nAttempted targeted validation with:\n- yarn jest packages/shared/src/dom-events/resize/resizeElement.test.ts --runInBand\n- yarn prettier --check packages/shared/src/dom-events/resize/resizeElement.ts packages/shared/src/dom-events/resize/resizeElement.test.ts\n\nBoth Yarn commands could not run in this checkout because the Yarn node_modules state file is missing and dependencies are not currently installed.