Add Internet OTA support for companion radio (usb/ble/wifi)#6
Merged
Conversation
Extends InternetOTA with an optional OTA_VARIANT path segment so the manifest URL can address companion's per-variant server layout (data/firmware/companion/<board>/<usb|ble|wifi>/), while the repeater's two-level layout (data/firmware/repeater/<board>/) stays unchanged. For usb/ble builds (no permanent WiFi link), the periodic check reuses board.startInternetOTA exactly like simple_repeater — it opens its own on-demand WiFiConnect via WIFI_SSID_1../WIFI_PWD_1.. and disconnects after. For wifi builds, which stay permanently connected for the app TCP bridge, the check instead reuses that existing WiFi link directly (spinning up a second WiFiConnect would disconnect the bridge, since WiFiMulti::run() drops any current connection not in its own AP list). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InternetOTAwith an optionalOTA_VARIANTpath segment so the manifest URL can address companion's per-variant server layout (data/firmware/companion/<board>/<usb|ble|wifi>/manifest.json), while the repeater's two-level layout (data/firmware/repeater/<board>/) stays unchanged.board.startInternetOTAexactly likesimple_repeater— opens its own on-demandWiFiConnect(viaWIFI_SSID_1../WIFI_PWD_1..) and disconnects after.WiFiConnect(which would disconnect the bridge, sinceWiFiMulti::run()drops any current connection not in its own AP list).Test plan
pio runsucceeds for all 9 companion environments (usb/ble/wifi × heltec_v4/heltec_v3/xiao_s3_wio)🤖 Generated with Claude Code