Move MESH_DEBUG/MESH_PACKET_LOGGING and companion WiFi creds to local config#8
Open
polipl wants to merge 1 commit into
Open
Move MESH_DEBUG/MESH_PACKET_LOGGING and companion WiFi creds to local config#8polipl wants to merge 1 commit into
polipl wants to merge 1 commit into
Conversation
… config
Every companion_radio/repeater/etc. env now picks up MESH_PACKET_LOGGING=1
and MESH_DEBUG=1 via a new ${poli_debug.build_flags} reference added to each
board's base section, instead of scattered (and partly disabled/commented)
inline defines. Likewise, every *_wifi companion env now pulls its
WIFI_SSID/WIFI_PWD from a new ${poli_wifi.build_flags} section instead of
hardcoded credentials in the tracked platformio.ini files.
Both [poli_debug] and [poli_wifi] are defined empty in the root
platformio.ini (mirroring [poli_build]) and populated by
build_firmware.sh's write_local_ini() into the gitignored
platformio.local.ini — WIFI_SSID/WIFI_PWD are mirrored from the existing
WIFI_SSID_1/WIFI_PWD_1 primary network so no credentials need to live in
tracked files.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MESH_PACKET_LOGGING=1/MESH_DEBUG=1via a new${poli_debug.build_flags}reference added to each board's base section — replacing ~36 scattered (and partly disabled/"DO NOT ENABLE") inline defines per file*_wificompanion env now pullsWIFI_SSID/WIFI_PWDfrom a new${poli_wifi.build_flags}section instead of hardcoded credentials committed directly inplatformio.ini[poli_debug]and[poli_wifi]sections are defined empty in the rootplatformio.ini(mirroring the existing[poli_build]convention) and populated bybuild_firmware.sh'swrite_local_ini()into the gitignoredplatformio.local.iniWIFI_SSID/WIFI_PWDare mirrored from the existingWIFI_SSID_1/WIFI_PWD_1primary network entries, so no WiFi credentials need to live in tracked filesTest plan
pio project configconfirms all 58 relevant envs resolve with exactly oneMESH_PACKET_LOGGING/MESH_DEBUGdefine each, and all*_wifienvs (incl._cloud_otavariants) get exactly oneWIFI_SSID/WIFI_PWDpair from[poli_wifi]_cloud_otaand a base_wifienv viabuild_firmware.shand confirm the binaries pick up the expected debug/WiFi flags