Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
======================================
Coverage 90.2% 90.2%
======================================
Files 14 14
Lines 858 858
======================================
Hits 774 774
Misses 75 75
Partials 9 9Continue to review full report at Codecov.
|
posener
requested changes
Oct 18, 2018
cmd/install/install.go
Outdated
| func zshrcPath() string { | ||
| if zDotDir := os.Getenv("ZDOTDIR"); zDotDir != "" { | ||
| f := filepath.Join(zDotDir, ".zshrc") | ||
| if info, err := os.Stat(f); err != nil || !info.IsDir() { |
Author
There was a problem hiding this comment.
Yes, this is completely wrong. Updated it
posener
reviewed
Oct 19, 2018
Owner
posener
left a comment
posener
left a comment
There was a problem hiding this comment.
Hi,
Thanks for this change.
Did you check it with this sort of folder?
Thanks
posener
approved these changes
Oct 19, 2018
posener
changed the title
Owner
|
@eikaas since we don't have any tests here, I will only merge it if you tested the change manually. |
|
Any chance of getting this conflict resolved and the fix merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mimics the default behavior of zsh