Use Parameter type alias for HashMap<String, ParameterValue>.#473
Open
teunbrand wants to merge 1 commit into
Open
Use Parameter type alias for HashMap<String, ParameterValue>.#473teunbrand wants to merge 1 commit into
Parameter type alias for HashMap<String, ParameterValue>.#473teunbrand wants to merge 1 commit into
Conversation
Replace all `HashMap<String, ParameterValue>` type annotations and `HashMap::new()` calls (where the result is typed as Parameters) with the `Parameters` type alias defined in `plot/types.rs`. Re-export `Parameters` from `lib.rs` for external consumers. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to fix a personal annoyance.
An alias is nicer to read that having to to mentally translate 'HashMap<String, ParameterValue>' to 'list of parameters' all the time throughout the code base. I contemplated make it a
structwith its own methods likeParameters.get_number("key")and whatnot, but decided losing the HashMap methods might be worse.