[Experimental] Use System.HashCode instead of JSONConvert.SerializeObject#27
[Experimental] Use System.HashCode instead of JSONConvert.SerializeObject#27
System.HashCode instead of JSONConvert.SerializeObject#27Conversation
|
Update: When checking if we still need the JSON serialisation properties for Edit: There's actually a few classes in |
Noted. I think it would be good to drop whatever classes we no longer use, and if possible repurpose this PR to have a reference Equals/GetHashCode implementation. |
|
@LucDeCaf can this be closed? |
|
@Chriztiaan yeah, outdated - I might re-open a new version in the future, but I'll need to first check if it's even an issue. |
This PR replaces the implementations of
GetHashCodeandEqualsforCrudEntryandSyncLocalDatabaseResult, which currently useJSONConvert.SerializeObjectfollowed by a string comparison, with manual implementations relying onSystem.HashCodeand some extra utility functions.TODO:
[JsonProperty]decorator is still needed onCrudEntryandSyncLocalDatabaseResult