Connatix: Enhance endpoint with DC

[karimMourra]

🔧 Type of changes

• bid adapter update

✨ What's the context?

Addresses #3834
Ports over the following changes from the Go repo prebid/prebid-server#4219
The change consists of appending the Data Center query param to the endpoint url based on the user ID to reduce latency.

🧠 Rationale behind the change

Product requirements from JWPConnatix

🧪 Test plan

Unit tests have been added

🏎 Quality check

• Are your changes following our code style guidelines?
• Are there any breaking changes in your code?
• Does your test coverage exceed 90%?
• Are there any erroneous console logs, debuggers or leftover code in your changes?

[AntoxaAntoxic]

    private Optional<String> getUserId(BidRequest request) {
        return Optional.ofNullable(request.getUser())
                .map(User::getBuyeruid)
                .filter(StringUtils::isNotBlank)
                .map(String::trim);
    }

[AntoxaAntoxic]

    private String getOptimalEndpointUrl(BidRequest request) {
        try {
            final URIBuilder uriBuilder = new URIBuilder(endpointUrl);
            return getUserId(request)
                    .map(this::getDataCenterCode)
                    .map(code -> uriBuilder.addParameter("dc", code))
                    .orElse(uriBuilder)
                    .build()
                    .toString();
        } catch (URISyntaxException e) {
            throw new PreBidException(e.getMessage());
        }
    }

[AntoxaAntoxic]

Result.withError(...) and create the error list later

[karimMourra]

@AntoxaAntoxic thank you for the review! I applied your suggestions

[AntoxaAntoxic]

please remove all added test JSON files

[AntoxaAntoxic]

please move creating an error list as closer as possible to the place it's used

[AntoxaAntoxic]

incorrect styling

    private HttpRequest<BidRequest> makeHttpRequest(BidRequest request,
                                                    Imp imp,
                                                    MultiMap headers,
                                                    String optimalEndpointUrl) {

        final BidRequest outgoingRequest = request.toBuilder().imp(List.of(imp)).build();
        return BidderUtil.defaultRequest(outgoingRequest, headers, optimalEndpointUrl, mapper);
    }

[AntoxaAntoxic]

static

[AntoxaAntoxic]

static

[AntoxaAntoxic]

please check other occurrences and fix them as well

assertThat(result.getValue).extracting(HttpRequest::getUri).containsOnly("dc=us-east-2");

[karimMourra]

@AntoxaAntoxic thanks for the review! all feedback addressed

[CTMBNara]

    private String getOptimalEndpointUrl(BidRequest request) {
        final Optional<String> dataCenterCode = getUserId(request)
                .map(ConnatixBidder::getDataCenterCode);

        if (dataCenterCode.isEmpty()) {
            return endpointUrl;
        }

        try {
            return new URIBuilder(endpointUrl)
                    .addParameter("dc", dataCenterCode.get())
                    .build()
                    .toString();
        } catch (URISyntaxException e) {
            throw new PreBidException(e.getMessage());
        }
    }

[CTMBNara]

I see that @AntoxaAntoxic asked you to change this piece of code. It seems a bit confusing to me (due to .map(<toBuilder>)), let's go back to the old version.

Please make this small change and we will merge the pr as soon as possible.

[karimMourra]

@CTMBNara addressed!