Added support for timeouts to lightweight semaphore#8
Open
cameron314 wants to merge 1 commit intopreshing:masterfrom
Open
Added support for timeouts to lightweight semaphore#8cameron314 wants to merge 1 commit intopreshing:masterfrom
cameron314 wants to merge 1 commit intopreshing:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi :-)
In case you're interested, I added support for timeouts to the LightweightSemaphore.
The platform-specific code is thanks to some pull requests I had on my concurrent queue (a lot of users wanted a blocking version with a timeout!), specifically this one and this one. My main contribution was the changes to the LightweightSemaphore itself (the loop at the end of waitWithPartialSpinning is kinda interesting).