-
Notifications
You must be signed in to change notification settings - Fork 648
UnderlineNav Overflow Fix #7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
| <Component | ||
| className={clsx(classes.UnderlineWrapper, className)} | ||
| ref={ref as ForwardedRef<HTMLDivElement>} | ||
| data-ready={ready ? 'true' : 'false'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we do data-ready={ready ? '' : undefined}? I swear we have docs about this somewhere but I can't find 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For sure! I just added undefined instead
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/12629 |
|
Integration test results from github/github-ui:
CI check runs linting, type checking, and unit tests. Check the workflow logs for specific failures. Need help? If you believe this failure is unrelated to your changes, please reach out to the Primer team for assistance. |
Part of https://github.com/github/primer/issues/6291
Improves CLS by adding
overflow: hiddenduring calculation of menu items.Base PR: #7463
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist