-
Notifications
You must be signed in to change notification settings - Fork 648
Refactor Breadcrumb to be more SSR friendly
#7502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 12c1d30 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the |
Breadcrumb to be more SSR friendly
Refactors the Breadcrumbs component to extract responsive overflow logic into a standalone hook (
useBreadcrumbsResponsive) and separate overflow menu component, improving code organization and enabling SSR-friendly usage patterns.Changelog
Changed
Refactor: Extract responsive breadcrumbs logic
useBreadcrumbsResponsivehook - Encapsulates all overflow calculation logic (resize observation, width measurements, visibility state) into a reusable hook that can be used independently for customimplementations
BreadcrumbsOverflowMenucomponent - Extracts the overflow menu dropdown into a standalone componentresponsiveprop to Breadcrumbs - allows opting out of automatic overflow handling for manual controluseBreadcrumbsResponsivefrom the package for consumers who need SSR-friendly conditional renderingFix: Prevent overflow during SSR
overflow: hiddento breadcrumbs container with menu or menu-with-root overflow modes to prevent content from overflowing before JavaScript calculates the overflow menuRollout strategy
Testing & Reviewing
Merge checklist