-
Notifications
You must be signed in to change notification settings - Fork 877
feat(docs): add frontmatter to llms.mdx
#7487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRoute updated to resolve pages from primary Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. No actionable comments were generated in the recent review. 🎉 Comment |
🍈 Lychee Link Check Report3660 links: ❌ Errors
Full Statistics Table
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@apps/docs/src/app/llms.mdx/`[[...slug]]/route.ts:
- Around line 12-19: The frontmatter string built in route.ts interpolates raw
values (page.data.title, page.data.description, page.url) which can break YAML;
update the frontmatter construction (the frontmatter constant) to escape/quote
these values safely before insertion—e.g., implement a helper (escapeYaml or
quoteYaml) and apply it to page.data.title, page.data.description and page.url
(or render multi-line description as a YAML block scalar) so special characters
like colons, quotes and newlines are handled correctly when building the
frontmatter string returned by getLLMText/page route.
- Around line 31-41: The current deduplication only removes prefix routes via
isPrefix but doesn't remove identical slugs coming from v7Params and v6Params;
update the params pipeline that builds allParams/allSlugs to first deduplicate
by the full slug path (e.g., use a Set of joined segments or JSON-stringify the
slug arrays) so generateParams outputs unique slug arrays before applying the
isPrefix filter; update references to v7Params, v6Params, allParams, allSlugs
and keep the existing isPrefix/prefix-filter logic but operate on the
deduplicated list returned from generateStaticParams.
Summary by CodeRabbit
New Features
Improvements