consider container type in PIResponse#79
Merged
lukasmatusiewicz merged 4 commits intomasterfrom Oct 20, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for smartphone container types in PIResponse, treating them as equivalent to push tokens for authentication purposes.
- Introduces
CONTAINER_TYPE_SMARTPHONEconstant to handle smartphone container types - Updates all push-related methods to also consider smartphone containers as push tokens
- Refactors duplicate type checking logic into a reusable helper method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| PIConstants.java | Adds CONTAINER_TYPE_SMARTPHONE constant and updates comment to reflect container types |
| PIResponse.java | Updates push token detection to include smartphone containers and refactors type checking logic |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
56
to
57
| public String passkeyChallenge = ""; | ||
| public String passkeyMessage = ""; | ||
| public String passkeyRegistration = ""; |
There was a problem hiding this comment.
The removal of passkeyMessage field appears unrelated to the PR's purpose of considering container types. This change should be in a separate commit or explained in the PR description to maintain clear change separation.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.