Merged
Conversation
Closed
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for multi-challenge enrollment flags in the privacyIDEA response parsing logic. The changes enable the library to capture whether enrollment via multi-challenge is required or optional from the server response.
- Added new boolean fields to track multi-challenge enrollment requirements
- Updated JSON parsing logic to extract multi-challenge enrollment flags from response details
- Refined imports to include only necessary token type constants
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| PIResponse.java | Added two new boolean fields for multi-challenge enrollment state and updated imports to be more specific |
| JSONParser.java | Added parsing logic to extract multi-challenge enrollment flags from JSON response details |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
nilsbehlen
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for handling multi-challenge enrollment flags in the privacyIDEA response parsing logic. The main changes introduce new fields to capture whether enrollment via multi-challenge is required or optional, and update the parsing logic to set these fields when processing interactive responses.
Multi-challenge enrollment support:
isEnrollViaMultichallengeandisEnrollViaMultichallengeOptionalto thePIResponseclass to indicate multi-challenge enrollment requirements.JSONParser.javato extractenroll_via_multichallengeandenroll_via_multichallenge_optionalfrom the response details when in interactive mode.validateCheckCancelEnrollmentto thePrivacyIDEAclass.Code organization: