Update to Codemirror v6#4152
Open
khanniie wants to merge 163 commits into
Open
Conversation
…t-file Editor file splitting: create new hint file
…ls-tidy Moves the tidier code and file mode utils out of editor file
I'm fairly certain that we can remove ```
if (!prevProps?.unsavedChanges) {
setTimeout(() => setUnsavedChanges(false), 400);
}
```
I looked at the git blame and it looks like the intention was to stop setting unsavedchanges to false when the files switched, but i think the solve that was implemented 9 years ago did something like "if c == false, c = false" and we should be able to safely remove it instead.
reference commit: 77e2f5b
…itoff-codemirror Convert Editor to functional, splits off CodeMirror code into its own file
…ybind fix: Add Keyboard Shortcut for the Color Picker #3867
renames p5CompletionPreview because it's more of a generic preview and not p5 specific. prep for an eventual folder reorganizing
…sistency fix: restore CM6 editor visual consistency#4144
…/p5.js-web-editor into develop-codemirror-v6
also pulled the keymap and styling specific files out of the stateUtils file, which was getting too big.
Release EnvironmentsThis Environment is provided by Release, learn more! 🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-5557d12d6d |
turns out it was using the monospace font from cm6 so we needed to set a style with more specificity
[CodeMirror v6] fix ctrl/cmd+enter inserting blank line
Develop codemirror v6
[CodeMirror v6] fix stale react state in cm6 update listener
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #3814
Changes:
Updates Codemirror 5 to Codemirror 6!
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123