Conversation
|
I'm not the best person to review github actions, but from what I know about them, this looks good to me. One more change I'd suggest is that we add the compiled library file to |
|
Yeah I thought about that but then the ci for the pull request previews wouldn't work. As example, you submitted a change and I would like to test that change, then I would need a build with the new binary in Processing to make sure it works. I think the only way would be to allow the binary to be part of the PR |
Oh, I see. You need the compiled binary to be in the PR so the CI testing will work. There's no way for the CI stuff to compile it itself, before running tests? |
|
Good you ask, I just realized only macOS can export for macOS so maybe it can just be part of the build chain. I was under the impression that libDifferent needed to be included on other platforms too In any case |
|
OK, good we talked this through and understand how everything will work moving forward. |
hx2A
left a comment
There was a problem hiding this comment.
Looks good! This will compile the native thinkdifferent library, needed for macOS computers
Closes #913
This GitHub Action will: