Adds gradient export to SVG library#929
Merged
Stefterv merged 1 commit intoprocessing:mainfrom Jan 21, 2025
Merged
Conversation
…dial gradients to export as SVG The extension handler is a copy of https://gist.github.com/msteiger/4509119 by Martin Steiger with minor changes for Processing Several classes and methods in PShapeSVG and PShapeJava2D have been made public or modified to support the export of gradients
Contributor
|
Hi @tracerstar, thank you for this PR! Could you provide an example on how this new functionality would be used? I'd like to test the functionality you wrote, other than that it looks good! |
Contributor
Author
Stefterv
approved these changes
Jan 20, 2025
Contributor
Stefterv
left a comment
There was a problem hiding this comment.
Great, tested on macOS arm64 and works as expected!
SableRaf
approved these changes
Jan 21, 2025
|
BIG |
Collaborator
|
@all-contributors please add @tracerstar for code |
Contributor
|
I've put up a pull request to add @tracerstar! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding an extension handler to the SVG library to allow linear and radial gradients to export correctly as SVG (currently they export as solid black fills).
The extension handler is a copy of https://gist.github.com/msteiger/4509119 by Martin Steiger with minor changes for Processing.
Several classes and methods in PShapeSVG and PShapeJava2D have been made public or modified to support the export of gradients.
Current SVG export of gradients results in
fill:noneon the shapes, leaving everything filled black. This adds gradients into the export handler, allowingfill:url(#gradientID)to work as expected.I originally made this pull request in August 2023 against the old processing4 repo, but I saw that git activity had recently started up again so wanted to make a new PR.