Added unit tests for handling key events in processing:core

[Rishab87]

I've added unit tests to test key events. Here are the tests that I added:

testSingleKeyPressAndRelease
testShiftAndLetterSequence
testControlAndLetterSequence
testAltAndLetterSequence
testKeyRepeat
testKeyRepeatEnabled
testKeyFocusLost

As expected testControlAndLetterSequence and testShiftAndLetterSequence fail (see #779)

Fixes #965

Update this PR also adds a fix to #779 , now all tests pass

Update, this also fixes #824

[Rishab87]

Just a follow up anything else I need to change here?

[SableRaf]

Hey @Rishab87, thanks for your contribution! We're busy right now preparing the release of Processing 4.4 but we'll review your PR as soon as we can.

[Rishab87]

Thanks for letting me know @SableRaf, please take your time.

[Rishab87]

Also apart from this should I start with addition of more tests by then?

[SableRaf]

Also apart from this should I start with addition of more tests by then?

If you'd like, but I'd suggest rather focusing on your GSoC application in the meantime :)

[Rishab87]

Sure @SableRaf , I'll focus on my application then in the meantime.

[Rishab87]

@SableRaf I've created first draft of my proposal, so should I start with writing other unit tests, like for math related functionalities their is no unit test currently present for it so should I continue with it?

[Rishab87]

I've pushed some changes which fixes #779 but I don't think it's the most optimised approach. It unregisters all the hashes with that key code

The issue seems to be when we press Ctrl and then A, Ctrl gets registered and ctrl+A gets registered, when we release ctrl we release 2 keys, ctrl and ctrl+A at the same time

I'm open to hearing your thoughts on this, will make changes accordingly.

[Stefterv]

Hi @Rishab87 Looks good, just a small readability improvement and some cleanup

[Stefterv]

Instead we can do

    pressedKeys.removeIf(hash -> {
      int pressedKeyCode = (int)(hash >> Character.SIZE);
      return pressedKeyCode == keyCode;
    });

[Stefterv]

Just use assertTrue

[Stefterv]

Same here

[Rishab87]

Thanks for the review @Stefterv , I've made those changes

[SableRaf]

@all-contributors please add @Rishab87 for code

[allcontributors]

@SableRaf

I've put up a pull request to add @Rishab87! 🎉