Fix: replace raw error messages with generic errors in auth routes#19
Merged
Merged
Conversation
The signup, reset-password, and update-password endpoints return raw Supabase error messages to the client. These can reveal internal details like "User already registered" (enabling account enumeration), database schema information, or rate limiting implementation details. Replace error.message with generic errors and log the original message server-side for debugging. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #18
Auth endpoints leak internal Supabase error messages that can enable account enumeration and information disclosure.
Changes
apps/web/src/app/api/auth/signup/route.ts: Replaceerror.messagewith generic "Signup failed"apps/web/src/app/api/auth/reset-password/route.ts: Replace with "Password reset request failed"apps/web/src/app/api/auth/update-password/route.ts: Replace with "Password update failed"console.error()for server-side debuggingTest plan
🤖 Generated with Claude Code