Skip to content

Fix: prevent race condition in bounty claim #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 1 commit into from
Jun 15, 2026
+8 −2
Merged

Fix: prevent race condition in bounty claim #24

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions apps/web/app/api/bounties/[id]/claim/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,20 @@ export async function POST(req: NextRequest, { params }: { params: Promise<{ id:
const coupons = await db.sql`SELECT * FROM coupons WHERE id = ${coupon_id}`;
if (!coupons.length) return NextResponse.json({ error: 'Coupon not found' }, { status: 404 });

// Mark bounty as claimed
// Mark bounty as claimed — atomic WHERE prevents race conditions
await db.sql`
UPDATE bounties
SET status = 'claimed', coupon_id = ${coupon_id}, claimer_did = ${did},
updated_at = ${new Date().toISOString()}
WHERE id = ${bountyId}
WHERE id = ${bountyId} AND status IN ('open', 'funded')
`;

// Verify the claim succeeded (handles concurrent claim race)
const verify = await db.sql`SELECT claimer_did FROM bounties WHERE id = ${bountyId}`;
if (verify.length && verify[0].claimer_did !== did) {
return NextResponse.json({ error: 'Bounty was already claimed by another user' }, { status: 409 });
}

// Attempt payout to claimer via web wallet
// Docs: POST /api/web-wallet/:id/prepare-tx then /broadcast
let payoutOk = false;
Expand Down
Loading