Skip to content

fix: validate recordId before split in googledns deleteRecord (#454) #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nikos1005 wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

fix: validate recordId before split in googledns deleteRecord (#454) #471

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/dns/googledns/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,9 @@ export default defineDns<Config>({
const token = await getAccessToken();
const project = config.projectId ?? _secret('GOOGLE_PROJECT_ID');
if (!project) throw new Error('GOOGLE_PROJECT_ID not set');
if (typeof recordId !== 'string' || !recordId.includes('/')) {
throw new Error(`Invalid recordId: ${recordId}. Expected format: "<type>/<FQDN>"`);
}
Comment on lines +126 to +128
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Empty segment edge cases pass validation

recordId.includes('/') accepts values like /example.com. or A/ — both contain a / but produce an empty type or name after the split. An empty type silently matches no records and the function returns without error; an empty name produces fqdn = '.' which is syntactically wrong and may generate a confusing API error. Adding a stricter pattern check would catch these at the validation boundary.

Suggested change
if (typeof recordId !== 'string' || !recordId.includes('/')) {
throw new Error(`Invalid recordId: ${recordId}. Expected format: "<type>/<FQDN>"`);
}
if (typeof recordId !== 'string' || !/^[^/]+\/[^/]+/.test(recordId)) {
throw new Error(`Invalid recordId: ${recordId}. Expected format: "<type>/<FQDN>"`);
}

const [type, name] = recordId.split('/');
// Need to fetch the rrset to get current rrdatas for the deletion entry.
const existing = (await this.listRecords(zoneId, config)).filter(
Expand Down