Skip to content

fix(dns): narrow Google DNS delete record inputs #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jorel97 wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −1
Open

fix(dns): narrow Google DNS delete record inputs #473

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4304ffb
fix(dns): narrow Google DNS record deletion inputs
Jorel97 May 29, 2026
d0c88b9
fix(dns): throw on unavailable Google DNS record
Jorel97 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/dns/googledns/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,20 @@ export default defineDns<Config>({
const project = config.projectId ?? _secret('GOOGLE_PROJECT_ID');
if (!project) throw new Error('GOOGLE_PROJECT_ID not set');
const [type, name] = recordId.split('/');
if (!type || !name) {
throw new Error('Google Cloud DNS deleteRecord: invalid record id');
}
// Need to fetch the rrset to get current rrdatas for the deletion entry.
const existing = (await this.listRecords(zoneId, config)).filter(
r => r.type === type && (r.name === name || r.name === name.replace(/\.$/, '')),
);
if (existing.length === 0) return;
const fqdn = name.endsWith('.') ? name : `${name}.`;
const ttl = existing[0].ttl;
const first = existing[0];
if (!first) {
throw new Error('Google Cloud DNS deleteRecord: matching record unavailable');
}
const ttl = first.ttl;
const res = await fetch(`${API}/projects/${project}/managedZones/${zoneId}/changes`, {
method: 'POST',
headers: { Authorization: `Bearer ${token}`, 'Content-Type': 'application/json' },
Expand Down