Skip to content

fix(marketplace): clamp listing page queries #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ralyodio merged 2 commits into from
May 29, 2026
Merged

fix(marketplace): clamp listing page queries #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e120ef
fix(marketplace): clamp listing page queries
Jorel97 May 29, 2026
53cf3f6
fix(marketplace): cap listing page bounds
Jorel97 May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
63 changes: 63 additions & 0 deletions src/app/api/mcp/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,69 @@ describe("GET /api/mcp", () => {
expect(json.listings).toHaveLength(0);
expect(json.total).toBe(0);
});

it("clamps invalid page values to the first page", async () => {
const range = vi.fn(() =>
Promise.resolve({ data: [], count: 0, error: null })
);

mockFrom.mockReturnValue({
select: () => ({
eq: () => ({
order: () => ({ range }),
}),
}),
});

const response = await GET(makeGetRequest({ page: "-1" }));
const json = await response.json();

expect(response.status).toBe(200);
expect(range).toHaveBeenCalledWith(0, 19);
expect(json.page).toBe(1);
});

it("truncates fractional page values before calculating ranges", async () => {
const range = vi.fn(() =>
Promise.resolve({ data: [], count: 0, error: null })
);

mockFrom.mockReturnValue({
select: () => ({
eq: () => ({
order: () => ({ range }),
}),
}),
});

const response = await GET(makeGetRequest({ page: "2.9" }));
const json = await response.json();

expect(response.status).toBe(200);
expect(range).toHaveBeenCalledWith(20, 39);
expect(json.page).toBe(2);
});

it("caps huge page values before calculating ranges", async () => {
const range = vi.fn(() =>
Promise.resolve({ data: [], count: 0, error: null })
);

mockFrom.mockReturnValue({
select: () => ({
eq: () => ({
order: () => ({ range }),
}),
}),
});

const response = await GET(makeGetRequest({ page: "1e308" }));
const json = await response.json();

expect(response.status).toBe(200);
expect(range).toHaveBeenCalledWith(1999980, 1999999);
expect(json.page).toBe(100000);
});
});

describe("POST /api/mcp", () => {
Expand Down
11 changes: 10 additions & 1 deletion src/app/api/mcp/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,15 @@ import { mcpListingSchema, slugify } from "@/lib/mcp/validation";
import { combinedScan, MCP_SCANNER_VERSION } from "@/lib/mcp/security-scan";
import { sanitizeSearchParams } from "@/lib/security/sanitize";

const MAX_PAGE = 100_000;

function parsePage(value: string | null) {
const parsed = Number(value || "1");
return Number.isFinite(parsed)
? Math.min(Math.max(1, Math.trunc(parsed)), MAX_PAGE)
: 1;
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.
Comment thread
greptile-apps[bot] marked this conversation as resolved.

/**
* GET /api/mcp - Public listing of active MCP servers
*/
Expand All @@ -16,7 +25,7 @@ export async function GET(request: NextRequest) {
const category = url.searchParams.get("category") || "";
const tag = sanitizeSearchParams(url, "tag");
const sort = url.searchParams.get("sort") || "newest";
const page = parseInt(url.searchParams.get("page") || "1");
const page = parsePage(url.searchParams.get("page"));
const limit = 20;
const offset = (page - 1) * limit;

Expand Down
63 changes: 63 additions & 0 deletions src/app/api/skills/route.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,69 @@ describe("GET /api/skills", () => {
expect(json.total).toBe(1);
expect(json.page).toBe(1);
});

it("clamps invalid page values to the first page", async () => {
const range = vi.fn(() =>
Promise.resolve({ data: [], count: 0, error: null })
);

mockFrom.mockReturnValue({
select: () => ({
eq: () => ({
order: () => ({ range }),
}),
}),
});

const response = await GET(makeGetRequest({ page: "-1" }));
const json = await response.json();

expect(response.status).toBe(200);
expect(range).toHaveBeenCalledWith(0, 19);
expect(json.page).toBe(1);
});

it("truncates fractional page values before calculating ranges", async () => {
const range = vi.fn(() =>
Promise.resolve({ data: [], count: 0, error: null })
);

mockFrom.mockReturnValue({
select: () => ({
eq: () => ({
order: () => ({ range }),
}),
}),
});

const response = await GET(makeGetRequest({ page: "2.9" }));
const json = await response.json();

expect(response.status).toBe(200);
expect(range).toHaveBeenCalledWith(20, 39);
expect(json.page).toBe(2);
});

it("caps huge page values before calculating ranges", async () => {
const range = vi.fn(() =>
Promise.resolve({ data: [], count: 0, error: null })
);

mockFrom.mockReturnValue({
select: () => ({
eq: () => ({
order: () => ({ range }),
}),
}),
});

const response = await GET(makeGetRequest({ page: "1e308" }));
const json = await response.json();

expect(response.status).toBe(200);
expect(range).toHaveBeenCalledWith(1999980, 1999999);
expect(json.page).toBe(100000);
});
});

describe("POST /api/skills", () => {
Expand Down
11 changes: 10 additions & 1 deletion src/app/api/skills/route.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ import { importSkillFromUrl } from "@/lib/skills/url-import";
import { isScanAcceptable } from "@/lib/skills/security-scan";
import { sanitizeSearchParams } from "@/lib/security/sanitize";

const MAX_PAGE = 100_000;

function parsePage(value: string | null) {
const parsed = Number(value || "1");
return Number.isFinite(parsed)
? Math.min(Math.max(1, Math.trunc(parsed)), MAX_PAGE)
: 1;
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.

/**
* Detect whether a submission looks like an MCP server listing based on title/tags.
*/
Expand All @@ -32,7 +41,7 @@ export async function GET(request: NextRequest) {
const category = url.searchParams.get("category") || "";
const tag = sanitizeSearchParams(url, "tag");
const sort = url.searchParams.get("sort") || "newest";
const page = parseInt(url.searchParams.get("page") || "1");
const page = parsePage(url.searchParams.get("page"));
const limit = 20;
const offset = (page - 1) * limit;

Expand Down
Loading