fix(pages): clamp public listing page values #337
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| import { describe, expect, it } from "vitest"; | ||
| import { parsePageParam } from "./pagination"; | ||
|
|
||
| describe("parsePageParam", () => { | ||
| it("defaults missing values to page 1", () => { | ||
| expect(parsePageParam(undefined)).toBe(1); | ||
| expect(parsePageParam(null)).toBe(1); | ||
| expect(parsePageParam("")).toBe(1); | ||
| }); | ||
|
|
||
| it("clamps invalid low values to page 1", () => { | ||
| expect(parsePageParam("-1")).toBe(1); | ||
| expect(parsePageParam("0")).toBe(1); | ||
| expect(parsePageParam("abc")).toBe(1); | ||
| }); | ||
|
|
||
| it("truncates fractional page values", () => { | ||
| expect(parsePageParam("2.9")).toBe(2); | ||
| }); | ||
|
|
||
| it("caps very large page values", () => { | ||
| expect(parsePageParam("999999999")).toBe(100_000); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| const DEFAULT_MAX_PAGE = 100_000; | ||
|
|
||
| export function parsePageParam( | ||
| value: string | null | undefined, | ||
| maxPage = DEFAULT_MAX_PAGE | ||
| ) { | ||
| const parsed = parseInt(value || "1", 10); | ||
| return Number.isFinite(parsed) | ||
| ? Math.min(Math.max(parsed, 1), maxPage) | ||
| : 1; | ||
| } | ||
|
Comment on lines
+1
to
+11
There was a problem hiding this comment.
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every non-ASCII decorative character in the PR's changed files has been replaced with a mojibake equivalent:
≈→≈,—→â€",→→â†',✕→✕,⚡→âš¡. These are the raw UTF-8 byte sequences of the originals re-encoded as Latin-1 then stored back as UTF-8 — a classic double-encoding error. A browser serving the UTF-8 page will render these literally (e.g. showing "â€" 50 âš¡" instead of "— 50 ⚡"), breaking visible content for all affected listing pages. The same corruption appears insrc/app/directory/page.tsx,src/app/for-hire/[[...tags]]/page.tsx,src/app/gigs/[[...tags]]/page.tsx,src/app/mcp/page.tsx,src/app/prompts/page.tsx, andsrc/app/skills/page.tsx— the pattern is present throughout the PR.