fix: ensure -pr http11 disables HTTP/2 fallback#2448
fix: ensure -pr http11 disables HTTP/2 fallback#2448innerpeace609 wants to merge 1 commit intoprojectdiscovery:devfrom
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughA single line is added to explicitly disable HTTP/2 attempt at the transport level by setting Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs). Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Neo - PR Security ReviewNo security issues found Highlights
Hardening Notes
Comment |
This PR fixes issue #2240 where the -pr http11 flag was being ignored due to the underlying transport falling back to HTTP/2. I have explicitly disabled ForceAttemptHTTP2 and cleared TLSNextProto in the transport configuration when the http11 protocol is selected.
/claim #2240
Summary by CodeRabbit