Skip to content

Initial implementation#1

Merged
mdnix merged 2 commits into
masterfrom
init-implementation
Apr 16, 2026
Merged

Initial implementation#1
mdnix merged 2 commits into
masterfrom
init-implementation

Conversation

@mdnix

@mdnix mdnix commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Checklist

  • The PR has a meaningful title. It will be used to auto-generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Update the documentation.
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@mdnix mdnix self-assigned this Apr 15, 2026
@mdnix mdnix added bump:minor Create a new minor release when merging the labeled PR enhancement New feature or request labels Apr 15, 2026
@github-actions

github-actions Bot commented Apr 15, 2026 •
edited
Loading

Copy link
Copy Markdown

🚀 This PR has been released as v0.1.0

Triggering workflows Release

🛠️ Auto tagging enabled with label bump:minor

@mdnix

mdnix commented Apr 15, 2026

Copy link
Copy Markdown
Collaborator Author

A few notes on design decisions:

  • The standard library function std.manifestIni() doesn't support multi-value keys (e.g. public-network-name appearing multiple times) so I still went with a custom rendering.
  • Both CCM and CSI charts are always compiled. Kapitan doesn't support conditional Helm chart compilation. This is a deliberate choice. When deploying on OpenStack you'll almost certainly need both the Cloud Controller Manager and the Cinder CSI driver anyway.

@mdnix mdnix requested a review from simu April 15, 2026 14:35
simu
simu reviewed Apr 16, 2026
View reviewed changes

@simu simu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, some suggestions/comments inline.

Comment thread component/main.jsonnet Outdated
Comment thread docs/modules/ROOT/pages/references/parameters.adoc Outdated
Comment thread component/main.jsonnet Outdated
Comment thread docs/modules/ROOT/pages/index.adoc Outdated
Comment thread docs/modules/ROOT/pages/index.adoc Outdated
Comment thread class/defaults.yml
Comment thread class/defaults.yml
Comment thread class/cloud-provider-openstack.yml
@mdnix mdnix requested a review from simu April 16, 2026 14:00
simu
simu approved these changes Apr 16, 2026
View reviewed changes

@simu simu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some additional inline notes, but they're getting quite nitpicky now ;)

Comment thread class/cloud-provider-openstack.yml
Comment thread class/defaults.yml Outdated
Comment thread component/app.jsonnet Outdated
Comment thread component/main.jsonnet
@mdnix mdnix force-pushed the init-implementation branch from 3788a5f to 5b4d48f Compare April 16, 2026 15:05
@mdnix

mdnix commented Apr 16, 2026

Copy link
Copy Markdown
Collaborator Author

LGTM. Some additional inline notes, but they're getting quite nitpicky now ;)

Thanks for the thorough review! Much appreciated.

@mdnix mdnix merged commit a7d6934 into master Apr 16, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simu simu simu approved these changes

Assignees

@mdnix mdnix

Labels

bump:minor Create a new minor release when merging the labeled PR enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mdnix @simu