fix(om2.0): consistency, GaugeHistogram and special values#2854
Open
fix(om2.0): consistency, GaugeHistogram and special values#2854
Conversation
There is no reset for GaugeHistograms , they represent a current and not a cumulative distribution. Reword the sentences copied from the cumulative histogram that are based on a different lifecycle and resets. Signed-off-by: György Krajcsovits <gyorgy.krajcsovits@grafana.com>
krajorama
requested review from
ArthurSens,
RichiH,
bwplotka,
dashpole and
ywwg
dashpole
reviewed
Feb 26, 2026
| Float and negative bucket values are allowed to make it possible to expose results of arithmetic operations on GaugeHistograms, such as the rate of change of a Histogram over time. | ||
|
|
||
| A GaugeHistogram SHOULD NOT include NaN measurements as including NaN in the Gsum will make the Gsum equal to NaN and mask the sum of the real measurements for the lifetime of the time series. If a GaugeHistogram includes NaN measurements, then NaN measurements MUST be counted in the Gcount and the Gsum MUST be NaN. | ||
| A GaugeHistogram SHOULD NOT include NaN measurements as including NaN in the Gsum will make the Gsum equal to NaN and mask the sum of the real measurements until NaNs are removed from the distribution. If a GaugeHistogram includes NaN measurements, then NaN measurements MUST be counted in the Gcount and the Gsum MUST be NaN. |
Contributor
There was a problem hiding this comment.
What does it mean for something to be removed from a distribution? Is that something supported by client libraries today?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no reset for GaugeHistograms , they represent a current and not a cumulative distribution. Reword the sentences copied from the cumulative histogram that are based on a different lifecycle and resets.