fix(update): bypass GitHub raw CDN cache for self-update#22
Open
fix(update): bypass GitHub raw CDN cache for self-update#22
Conversation
The `crab update` command was reporting "Already up to date" even after a new version was merged, because raw.githubusercontent.com serves cached content (max-age=300). Add cache-busting via Cache-Control header and timestamp query param. Also validate the downloaded file contains a version string before replacing the binary. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crab updatewas always reporting "Already up to date" after a new version was merged becauseraw.githubusercontent.comserves cached content (max-age=300)Cache-Control: no-cacheheader and a timestamp query parameter to force fresh downloadsTest plan
crab updateimmediately after merging a version bump — should detect the new version instead of reporting "Already up to date"crab updatewhen already on latest — should correctly report "Already up to date"🤖 Generated with Claude Code