Skip to content

fix: code scanning alert 10 in provider dependency install#98

Draft
jbeckwith-oai wants to merge 1 commit intomainfrom
codex/fix-codeql-alert-10-npm-install
Draft

fix: code scanning alert 10 in provider dependency install#98
jbeckwith-oai wants to merge 1 commit intomainfrom
codex/fix-codeql-alert-10-npm-install

Conversation

@jbeckwith-oai
Copy link
Copy Markdown
Contributor

@jbeckwith-oai jbeckwith-oai commented Apr 13, 2026

Summary

  • move provider dependency installation to execFileSync with explicit argv
  • keep the existing cwd, timeout, and error swallowing behavior
  • add a unit test that verifies npm is invoked without a shell string

Root Cause

The verify path built a shell command with the output directory embedded in it before running npm install.

Validation

  • npm test -- src/agent/loop-install.test.ts
  • npm run build

@jbeckwith-oai jbeckwith-oai changed the title [codex] Fix code scanning alert 10 in provider dependency install fix: code scanning alert 10 in provider dependency install Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant