Skip to content

[codex] Fix code scanning alert 2 in generated config path flow#99

Closed
jbeckwith-oai wants to merge 1 commit intomainfrom
codex/fix-codeql-alert-2-config-outputdir
Closed

[codex] Fix code scanning alert 2 in generated config path flow#99
jbeckwith-oai wants to merge 1 commit intomainfrom
codex/fix-codeql-alert-2-config-outputdir

Conversation

@jbeckwith-oai
Copy link
Copy Markdown
Contributor

Summary

  • keep the user-facing generated config path unchanged
  • track a separate relative verify path for promptfoo eval inside the output directory
  • add a regression test for generated file and verify paths

Root cause

CodeQL tracked the user-controlled output directory into the generated config path and then into the later promptfoo eval shell command.

Validation

  • npm test -- src/generator/config-outputdir.test.ts
  • npm run build

@jbeckwith-oai
Copy link
Copy Markdown
Contributor Author

Superseded by #101 after collapsing the stacked promptfoo verification alerts into a single PR.

@jbeckwith-oai
Copy link
Copy Markdown
Contributor Author

Closing this draft in favor of #101, which now carries alerts 1-3 together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant