fix(mcp): drop search scores, fix refs threshold#34
Merged
Conversation
Search results displayed RRF fusion scores as percentages (always ~1-2%), which were meaningless to agents. Removed score display from both formatters, added a result count preamble, and removed scoreThreshold from the MCP tool schema. Also fixed SearchService defaulting scoreThreshold to 0.7 which silently filtered out all results for dev_refs since RRF scores are ~0.01. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev_refsreturning no results via MCP.SearchServicedefaultedscoreThresholdto 0.7, silently filtering all results since RRF scores are ~0.01. Changed default to 0.Found N results for "query" | showing top KscoreThresholdfrom MCP tool schema. Core API retains it for CLI--thresholdflag.Test plan
pnpm build— passespnpm test— 1764 tests passpnpm typecheck— passesnode packages/dev-agent/dist/cli.js search "SearchAdapter"— no scores in outputnode packages/dev-agent/dist/cli.js refs "SearchAdapter"— finds symboldev_searchshows no scoresdev_refsfinds symbols that previously returned NOT_FOUND