macOS Intel CI#135
Open
TheMrIron2 wants to merge 21 commits into
Open
Conversation
Replaced a bad path. On modern macOS, both `TARGET_OS_MAC` and `__APPLE__` can be visible. So the old "no fdopen()” path runs and the macro replaces fdopen() with NULL and corrupts it.
Allow build script to detect if a local version of python3.11 exists rather than force it
This could sometimes fail if the local machine didn't have python3.11 and brew was not informed to download it. Fixed this oversight.
bucanero
reviewed
Jun 6, 2026
Comment on lines
+12
to
+13
| if [ ! -f config.guess ]; then wget --continue https://raw.githubusercontent.com/gcc-mirror/gcc/master/config.guess; fi | ||
| if [ ! -f config.sub ]; then wget --continue https://raw.githubusercontent.com/gcc-mirror/gcc/master/config.sub; fi |
Contributor
There was a problem hiding this comment.
we shouldn't use this mirror with old config files. I think we can do the same you did on ps3libraries repo, and add the get_config script, that tries to download but has a fallback.
Also we remove the duplicate download on gcc/binutils/ppu/spu and have a single download point.
Author
There was a problem hiding this comment.
Agreed, thanks for the catch.
Same behaviour as ps3libraries - check Savannah, and if not, fall back on local copy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working macOS CI builds with GitHub actions.
Main changes:
macos-15-intelas stable target with correct stagingzlib)Messy commit history due to CI retesting so squash and merge if approved.