Open
Conversation
add slider click functionality and this will only work for a slider having one thumb
|
@ptomasroos Do you need any help to merge this one? Pretty usefull. |
Owner
I don’t have any working dev Environment to verify this pull request. If you could help out in the testing I’m willing to merge it |
|
@ludovicthomas Can you help him? I really need this :) |
|
Sorry at the end I was not in the need of a multi-slider lib, but just a single slider with lot of customisation, so I moved to another lib. If you really need this, just test this PR, and show screenshot of how it works on several devices, and go for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you for writing such a great library for sliders. I have seen few issues regarding the feature to allow click on slider to move the thumb. Also, I have a scenario where I needed the same functionality. So, I decided to get this work done and I have managed to add this functionality for a slider having one thumb. I have created a request to merge my code into your's master. SO, everyone who needed the click functionality will take advantage from it.
Thanks!