feat: added props trackOneRender, support user deliver custom element…#240
Open
itenl wants to merge 111 commits intoptomasroos:masterfrom
Open
feat: added props trackOneRender, support user deliver custom element…#240itenl wants to merge 111 commits intoptomasroos:masterfrom
itenl wants to merge 111 commits intoptomasroos:masterfrom
Conversation
…vements Improve multislider
…equest ignore termination request
Fix valueToPosition converter
it doesn't work on android in production mode new impl not that easy for dummies like me
return old createArray implementation
Add currentValue prop type to DefaultMarker component.
* Removed getDerivedState -> componentDidUpdate * Fixed comparison Recreate in the case props has changed not the props vs the local state
* add types * remove unused leftDiff * add customLabel to types * add enableLabel type
* Update README.md * Update README.md * Update README.md
The fact that this function is still returning a position when value is undefined was causing me an issue in single slider mode as under some conditions (after changing min and max values) it was setting positionTwo equal to max. I think it's better it returns undefined when value is undefined
…ers. (ptomasroos#191) Co-authored-by: Thiago <thiago@fuze.cc>
Cleaned up indentations while keeping original code style
* Fix ptomasroos#45 * Fix ptomasroos#45 for any value of snapped prop and centralise prettier config * bugfix: add default value to markerSize
…roos#200) * Fix ptomasroos#45 * Fix ptomasroos#45 for any value of snapped prop and centralise prettier config * bugfix: add default value to markerSize * doc: README.md updated
* fix: Reenable allowOverlap for large sliders If your slider goes from, let's say, 0 to 10: - `this.optionsArray = [0, 1, ... 10];` => its length is 11 - however, `this.props.sliderLength` should only be divided by 10 (representing the 10 sections `0-1`, `1-2`, ..., `9-10`) The fix is then simply to replace L56 by ` this.stepLength = this.props.sliderLength / (this.optionsArray.length - 1);` * docs: Explicit the unit used by minMarkerOverlapDistance for more clarity One could think it was about steps
* feat: Allow expressing overlap distance without re-computing stepLength * refactor: Suggest reducing number of ternary conditions
Co-authored-by: Jascha Kanngiesser <jascha.kanngiesser@sap.com>
* * Adding so its possible to show steps - Show step labels - Show step marks on the track - Customizable step labels, prefix and suffix styling et. - Customizable styling for step container, step label and step markers * Adding smooth-snapped * Added docs
… ( react-native-linear-gradient )
itenl
force-pushed
the
feat-add-props-trackOneRender
branch
from
edcc127 to
63e7b4a
Compare
ArtLavr
approved these changes
Jan 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added props trackOneRender