Skip to content

Add resiliant repair for raw manifest data on sync#2382

Open
mdellweg wants to merge 1 commit into
pulp:mainfrom
mdellweg:resiliant_manifest_sync
Open

Add resiliant repair for raw manifest data on sync#2382
mdellweg wants to merge 1 commit into
pulp:mainfrom
mdellweg:resiliant_manifest_sync

Conversation

@mdellweg
Copy link
Copy Markdown
Member

@mdellweg mdellweg commented Jun 2, 2026

In case the data field was not properly populated during sync, we download it again and save it to the database.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

In case the data field was not properly populated during sync, we
download it again and save it to the database.
@mdellweg
Copy link
Copy Markdown
Member Author

mdellweg commented Jun 3, 2026

Since the other patch (revert) landed in 2.26, should we backport this to 2.27 and 2.28?
Would that be enough runway to make the final migration in 2.29?

@dralley
Copy link
Copy Markdown
Contributor

dralley commented Jun 3, 2026

If this is going in main then I think it would make sense to backport, yes

Copy link
Copy Markdown
Contributor

@gerrod3 gerrod3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need this change here:

if manifest := await Manifest.objects.filter(
digest=digest, pulp_domain=get_domain()
).afirst():
content_data = json.loads(manifest.data)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants