Add a ResourceBudget mechanism which keeps disk usage in check during syncs#7649
Draft
Add a ResourceBudget mechanism which keeps disk usage in check during syncs#7649
Conversation
dralley
force-pushed
the
resource-budget
branch
from
ffc20a0 to
3b86771
Compare
mdellweg
reviewed
Apr 27, 2026
| When set, small artifacts will download with high concurrency while large artifacts | ||
| will automatically throttle to avoid exhausting disk space. | ||
|
|
||
| Defaults to 5120 (5gb) |
Member
There was a problem hiding this comment.
Is this a hard limit? Will this option prevent syncs to succeed with one 6gb file?
(Not that this is a bad thing, just maybe worth mentioning. TBF the available diskspace is already a hard limit...)
Contributor
Author
There was a problem hiding this comment.
It should always let one file through at a time no matter how large. In theory
Member
There was a problem hiding this comment.
Nice, then we don't need to mention it.
Member
There was a problem hiding this comment.
IMO it's worth adding a note that this does not prevent bigger to be synced.
pedro-psb
reviewed
Apr 27, 2026
Member
There was a problem hiding this comment.
As this is user facing documentation I would prefer dropping specific references to ArtifactDownloader and ArtifactSaver.
Artifacts stay on disk between the ArtifactDownloader stage and the ArtifactSaver stage. If too many large files build up, it can exceed the allotted filesystem space of the working directory. Previously we used unecessarily small batch sizes by default in order to ensure the worst case was avoided. This approach dynamically controls how much disk space is being used by the task and provides backpressure when the limit is exceeded, flushing batches and preventing new artifacts from being downloaded. closes pulp#7559 Assisted-By: claude-opus-4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Checklist
See: Pull Request Walkthrough