Skip to content

(MAINT) Fixing issue with OS not being in FacterDB's fact set #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tu2607 wants to merge 2 commits into from
+223 −141
Closed

(MAINT) Fixing issue with OS not being in FacterDB's fact set #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c33a65
(MAINT) Bump facterdb version up to support Ubuntu 24.04
Tu2607 Feb 10, 2026
187f173
(MAINT) Update Benchmark class to use an internal mapping of supporte…
Tu2607 Feb 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
fail-fast: false
matrix:
ruby_version:
- '2.7'
# - '2.7'
- '3.2'
steps:
- name: Checkout
Expand Down Expand Up @@ -54,4 +54,6 @@ jobs:
run: bundle exec rake 'sce:fixtures'

- name: Run RSpec
run: bundle exec rake spec
# Going to use `rpsec` instead of `bundle exec rake spec` and manually feed it the pattern of spec files to run.
# `bundle exec rake spec` is running into some issue with the pattern defined in the Rakefle and was only running 8 tests.
Comment on lines +57 to +58
Copy link
Collaborator

@hsnodgrass hsnodgrass Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typically want to include the error name and context when you comment stuff like this

Copy link
Contributor Author

@Tu2607 Tu2607 Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a strange error. Not even a name to it. Just this

AMER-Tu-Vu:abide_dev_utils tuvu$ bundle exec rake spec
3ede072ed4e5c4a829aa377f788ff268e800cc92        HEAD
dae6cce198b012e2ebcd71b676e8997afb10be71        HEAD
/Users/tuvu/.asdf/installs/ruby/3.3.6/bin/ruby -I/Users/tuvu/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.6/lib:/Users/tuvu/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.7/lib /Users/tuvu/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.6/exe/rspec spec/abide_dev_utils/cli_spec.rb spec/abide_dev_utils/ppt/facter_utils_spec.rb spec/abide_dev_utils/ppt/new_obj_spec.rb spec/abide_dev_utils/sce/benchmark_spec.rb spec/abide_dev_utils/xccdf/diff/benchmark_spec.rb spec/abide_dev_utils/xccdf/parser/objects_spec.rb spec/abide_dev_utils/xccdf/parser_spec.rb spec/abide_dev_utils/xccdf_spec.rb spec/abide_dev_utils_spec.rb
/Users/tuvu/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/puppet-8.16.0-universal-darwin/lib/puppet.rb:38: warning: syslog was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.4.0.
You can add syslog to your Gemfile or gemspec to silence this warning.
.......

Finished in 0.03705 seconds (files took 16.6 seconds to load)
8 examples, 0 failures

/Users/tuvu/.asdf/installs/ruby/3.3.6/bin/ruby -I/Users/tuvu/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.6/lib:/Users/tuvu/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/rspec-support-3.13.7/lib /Users/tuvu/.asdf/installs/ruby/3.3.6/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.6/exe/rspec spec/abide_dev_utils/cli_spec.rb spec/abide_dev_utils/ppt/facter_utils_spec.rb spec/abide_dev_utils/ppt/new_obj_spec.rb spec/abide_dev_utils/sce/benchmark_spec.rb spec/abide_dev_utils/xccdf/diff/benchmark_spec.rb spec/abide_dev_utils/xccdf/parser/objects_spec.rb spec/abide_dev_utils/xccdf/parser_spec.rb spec/abide_dev_utils/xccdf_spec.rb spec/abide_dev_utils_spec.rb failed

Looked like it did not like the spec pattern provided through the Rakefile so I poke around but haven't yet find the accurate fix. Doing bundle exec rspec and passed the pattern in worked so it's a bit confusing.

run: bundle exec rspec spec/abide_dev_utils_spec.rb spec/abide_dev_utils/**/*_spec.rb
Loading