Skip to content

Fix type checker errors #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adsharma merged 2 commits into from
May 29, 2025
Merged

Fix type checker errors #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e97372
Fix: Add pyright ignores for CFFI dynamic attributes in re.py
google-labs-jules[bot] May 29, 2025
d187ca4
Refactor: Use generic type: ignore for CFFI attributes in re.py
google-labs-jules[bot] May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/stdlib/re.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ def search(self, text: str) -> str | None:
result_bytes = cast(bytes, ffi.string(result))
return result_bytes.decode("utf-8")
finally:
lib.free(ptr)
lib.free(ptr) # type: ignore[attr-defined]
return None

def findall(self, text: str) -> list[str]:
Expand All @@ -68,7 +68,7 @@ def findall(self, text: str) -> list[str]:
i += 1
finally:
# Free the allocated memory
lib.free_matches(matches_ptr)
lib.free_matches(matches_ptr) # type: ignore[attr-defined]
return matches

def sub(self, replacement: str, text: str) -> str:
Expand All @@ -82,7 +82,7 @@ def sub(self, replacement: str, text: str) -> str:
result_bytes = cast(bytes, ffi.string(result))
return result_bytes.decode("utf-8")
finally:
lib.free(ptr)
lib.free(ptr) # type: ignore[attr-defined]
return text # Return the original text if substitution fails


Expand Down