Conversation
…ing where the error could show up
…the keyword get_vec
…ssing a FemField to basis projector
…eriodic cases, rectangular tests for the basis projection operators
… test for the basis projection operator on mapped domains
…njugate gradient (stabilized) solvers
delete useless space
…rix so that you don't have to compute it, particularly usefull when transposing and one can now pass the space data in order to avoid multiple computation of the same data
…ficient are Femfields
added 15 commits
October 10, 2023 16:41
…the issue with the symbolic space
campospinto
requested changes
Oct 25, 2023
Collaborator
campospinto
left a comment
campospinto
left a comment
There was a problem hiding this comment.
Thanks Valentin this is useful ! I added a few comments and suggestions
campospinto
reviewed
Nov 29, 2023
Collaborator
|
Thanks Yaman for these commits 👍 |
Member
If only I had not introduced a bug! 😅 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just adds some documentation to the methods and properties of DiscreteDerham.
This was discussed on PR #282 but then was merged before the whole documentation was added