Replace mypy by pyright#1019
Conversation
|
Docs preview: |
Merging this PR will not alter performance
Comparing Footnotes
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 58f5a056b3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| try: | ||
| if self._uds is None: | ||
| kwargs = { | ||
| kwargs: dict[str, typing.Any] = { |
There was a problem hiding this comment.
Initialize retry trace kwargs before the try
With the new pyright gate enabled, this branch-local kwargs declaration still makes the check fail: pyright --help defines the positional arguments as files..., and running pyright src/httpcore2/httpcore2/_async/connection.py reports "kwargs" is possibly unbound at the retry trace on line 148. Because scripts/check now runs pyright over src/httpcore2, the replacement type-check step exits non-zero before the rest of CI can pass; hoist/initialize the retry trace kwargs (or avoid reusing the branch-local variable in the except).
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
2 issues found across 35 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
No description provided.