-
Notifications
You must be signed in to change notification settings - Fork 303
Update some examples to use new arviz #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
a52d1fe
update to use new arviz
aloctavodia acf7867
add more examples
aloctavodia 8c3bac6
update BEST example
aloctavodia 22165ed
update per comments
aloctavodia ff15531
update BF example
aloctavodia 6143142
update model averaging
aloctavodia ea1ce08
update model averaging
aloctavodia f1a4649
update and modify example
aloctavodia e13d00c
update data container example
aloctavodia c08058a
update data container example
aloctavodia 54e4195
update more examples
aloctavodia 446de4a
remove unused code
aloctavodia 88d30c3
rerun examples
aloctavodia 9c76968
rerun examples
aloctavodia 03819d5
update rugby example
aloctavodia b81ae68
update itr nba example
aloctavodia 6fe6b1b
allow links from EABM online book
OriolAbril df13827
add more examples
aloctavodia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My main comment is probably not actionable but might be worth to keep in mind for arviz development. I am not sure I can see this as it is a comparison between this figure and one a few sections higher. Does
plot_ppc_pavasupport dict input to show both models, if not, do you think that is useful to add?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only ones supporting more than one model are plot_forest and plot_dist. Not sure how useful, it could be ok for
plot_ppc_pavaand maybeplot_ppc_pit. Maybe something more general is to have something similar tocombine_plotsbut that works for different data. So we can create a single figure with one model per row or column, so comparisons are easier to see and present.