Draft
Conversation
d9023ab to
3481fea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking into adding tests (issue #19), and it looks like we can run a test step in cibuildwheel after each wheel is built, simple! 🥳
https://cibuildwheel.readthedocs.io/en/v2.16.2/options/#testing
So I've added
pyusbas a test requirement and it runspython test.py.I was planning to add this as part of PR #20, but unfortunately the tests are failing on Linux, so I didn't want that to be a blocker for that PR.
This PR is running on top of the main branch without any other modifications, to test the current wheels, which I assume should be working.
Test result from my fork: https://github.com/carlosperate/libusb-package/actions/runs/6975861223/job/18983558875
libusb-package/test.py
Lines 13 to 17 in 7a62b64
libusb-package/src/libusb_package/__init__.py
Lines 66 to 87 in 7a62b64