recwarn: improved warns(match=...) error message on regex mismatch (closes #11225)#14310
Open
JaeHyuckSa wants to merge 3 commits intopytest-dev:mainfrom
Open
recwarn: improved warns(match=...) error message on regex mismatch (closes #11225)#14310JaeHyuckSa wants to merge 3 commits intopytest-dev:mainfrom
warns(match=...) error message on regex mismatch (closes #11225)#14310JaeHyuckSa wants to merge 3 commits intopytest-dev:mainfrom
Conversation
warns(match=...) error message on regex mismatch (closes #11225)
293241c to
b4e2d97
Compare
…loses pytest-dev#11225) Signed-off-by: JaeHyuckSa <jaehyuck.sa.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
pytest.warns(match=...), even if a warning of the expected type was emitted, the first sentence of the error message said "DID NOT WARN" when the regex did not match. Since this made it seem as though no warning had been emitted at all, I updated it to make the situation clearer.Before:
After:
Closes #11225
closes #XYZWto the PR description and/or commits.Co-authored-bycommit trailers.changelogdirectory.AUTHORSin alphabetical order.