fix: allow HIDDEN_PARAM in parametrize ids type annotation#14312
Closed
r266-tech wants to merge 1 commit intopytest-dev:mainfrom
Closed
fix: allow HIDDEN_PARAM in parametrize ids type annotation#14312r266-tech wants to merge 1 commit intopytest-dev:mainfrom
r266-tech wants to merge 1 commit intopytest-dev:mainfrom
Conversation
The parameter of currently has type , but should also accept (a sentinel). This fixes mypy errors when using . Fixes pytest-dev#14234
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add to the parameter type union in overloads.
Why
Currently, the parameter type is , but (a sentinel) is a valid value that should be accepted. This causes mypy to report a false positive:
The field already accepts , so this is consistent.
Changes
Fixes #14234