Fix _as_numpy_array: use variable obj instead of string literal "obj"#14472
Merged
Conversation
The second hasattr call in _as_numpy_array incorrectly passed the string literal "obj" instead of the variable obj when checking for __array_interface__. This caused objects implementing only __array_interface__ (without __array__) to not be recognized as numpy-like arrays by pytest.approx. Closes pytest-dev#14456
psf-chronographer
Bot
added
the
bot:chronographer:provided
bluetech
approved these changes
May 14, 2026
bluetech
added
the
backport 9.0.x
Backport to 9.0.x: 💚 backport PR created✅ Backport PR branch: Backported as #14480 🤖 @patchback |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second hasattr call in
_as_numpy_arrayincorrectly passed the string literal"obj"instead of the variableobjwhen checking for__array_interface__. This caused objects implementing only__array_interface__(without__array__) to not be recognized as numpy-like arrays bypytest.approx.Closes #14456