feat: Add RaffleForGood - Decentralized raffle system with Pyth Entropy#84
Open
NicoCaz wants to merge 1 commit intopyth-network:mainfrom
Open
feat: Add RaffleForGood - Decentralized raffle system with Pyth Entropy#84NicoCaz wants to merge 1 commit intopyth-network:mainfrom
NicoCaz wants to merge 1 commit intopyth-network:mainfrom
Conversation
- Implements Pyth Entropy V2 for verifiable randomness - Factory pattern for easy raffle creation - Binary search O(log n) for winner selection - OpenZeppelin security patterns (ReentrancyGuard, PullPayment) - Deployed on Base Sepolia with 10+ active raffles - 0.05% platform fee for sustainable crowdfunding - Comprehensive README with deployment and usage examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solid Pyth Entropy integration. The request-callback flow is implemented correctly with proper state management, fee handling, and security checks. Binary search for winner selection (O(log n)) is smart - scales to millions of participants efficiently. Code is clean and follows OpenZeppelin best practices (ReentrancyGuard, PullPayment).
Minor Issues, the forceSelectWinner() function bypasses Pyth Entropy - probably for testing but could be confusing. Consider removing it or clearly marking as test-only. Also, the commented-out time validation in requestEntropy() should either be removed or explained.
my main repo: https://github.com/NicoCaz/eth-global-hackathon
visit: https://tanly.app/