tests: make tests compatible with rich 14.3.3#1678
Conversation
It seems that with the upgrade to rich 14.3.3 (what we have in openSUSE/Tumbleweed) `stylize` function eats EOLs. I have modified tests to acommodate that, and I hope it should be universal enough so that even with older versions of rich nothing should break. Signed-off-by: Matěj Cepl <mcepl@cepl.eu>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1678 +/- ##
=======================================
Coverage 99.59% 99.59%
=======================================
Files 23 23
Lines 5677 5677
=======================================
Hits 5654 5654
Misses 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
|
@mcepl What version of @kmvanbrunt is intimately familiar with the recent Regardless, you could need to run |
|
The issue isn't with You are using a setup with a new version of |
|
On Sat Jun 6, 2026 at 9:06 PM CEST, Kevin Van Brunt wrote:
You are using a setup with a new version of `cmd2` (no monkey patch) and an old version of Rich (14.3.3) which does not include the fix. It's an incompatible configuration. ***@***.*** mentioned, `cmd2` requires `rich >=15.0.0`.
Yes, you are right, with rich 15.0.0 the test suite passes. You can close this ticket.
|
It seems that with the upgrade to rich 14.3.3 (what we have in openSUSE/Tumbleweed)
stylizefunction eats EOLs. I have modified tests to acommodate that, and I hope it should be universal enough so that even with older versions of rich nothing should break.