fix refleaks from suspended frames#512
Merged
Merged
Conversation
jamadden
reviewed
Jun 16, 2026
jamadden
reviewed
Jun 17, 2026
jamadden
left a comment
jamadden
left a comment
Contributor
There was a problem hiding this comment.
This is a work-in-progress I know, but here's a review of what I'm seeing so far.
jamadden
requested changes
Jun 17, 2026
jamadden
left a comment
jamadden
left a comment
Contributor
There was a problem hiding this comment.
One thing I'm pretty sure needs changed, and some discussion about ignoring the leak checks.
Contributor
|
Oh, I neglected to add: I've run the gevent test suite, which exercises greenlet hard, with this set of changes on 3.14 and 3.15 without any issues. |
Contributor
Author
|
Ok, it looks like it only fails for 3.10 on Windows, I'll add ignore for that. |
jamadden
approved these changes
Jun 17, 2026
Contributor
|
Thanks! Are you planning any more PRs, or am I good to make a release sometime in the next few days? |
jamadden
added a commit
that referenced
this pull request
Jun 17, 2026
Contributor
Author
No, the work is complete, feel free to make a release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes refleaks of greenlet because of refs from suspended frames which were not previously cleared.
Follows up from #511
cc @jamadden