Skip to content

feat: source resolver configuration#1052

Draft
tiran wants to merge 1 commit intopython-wheel-build:mainfrom
tiran:new-resolver-config2
Draft

feat: source resolver configuration#1052
tiran wants to merge 1 commit intopython-wheel-build:mainfrom
tiran:new-resolver-config2

Conversation

@tiran
Copy link
Copy Markdown
Collaborator

@tiran tiran commented Apr 13, 2026

Pull Request Description

What

Introduce new configuration for source resolver and downloads. The new system uses profiles for common tasks:

  • pypi-sdist: resolve versions of sdists from PyPI, download sdist
  • pypi-prebuilt: resolve versions of platform wheels from PyPI, download pre-built wheel from PyPI.
  • pypi-download: resolve versions of any package from PyPI, download from external URL (with {version} variable)
  • pypi-git: resolve versions for any package from PyPI, git clone (with {version} variable)
  • versionmap-git: resolve with a version map, git clone
  • github-tag-download: resolve from GitHub tag, download tarball
  • github-tag-git: resolve from GitHub tag, git clone
  • gitlab-tag-download: resolve from GitLab tag, download tarball
  • gitlab-tag-git: resolve from GitLab tag, git clone
  • not-available: block resolving
  • hook: call Fromager hooks

The new settings will eventually replace download_source, resolver_dist, and git_options top-level options as well as wheel_server_url and pre_built flags for variants.

Why

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 13, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 66af919e-15de-469d-ad3f-3e03ef0dadbc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tiran
Copy link
Copy Markdown
Collaborator Author

tiran commented Apr 13, 2026

The tests are going to fail. I have not updated the test cases and test configs.

Introduce new configuration for source resolver and downloads. The new
system uses profiles for common tasks:

- `pypi-sdist`: resolve versions of sdists from PyPI, download sdist
- `pypi-prebuilt`: resolve versions of platform wheels from PyPI,
  download pre-built wheel from PyPI.
- `pypi-download`: resolve versions of any package from PyPI, download
  from external URL (with `{version}` variable)
- `pypi-git`: resolve versions for any package from PyPI, git clone
  (with `{version}` variable)
- `versionmap-git`: resolve with a version map, git clone
- `github-tag-download`: resolve from GitHub tag, download tarball
- `github-tag-git`: resolve from GitHub tag, git clone
- `gitlab-tag-download`: resolve from GitLab tag, download tarball
- `gitlab-tag-git`: resolve from GitLab tag, git clone
- `not-available`: block resolving
- `hook`: call Fromager hooks

The new settings will eventually replace `download_source`,
`resolver_dist`, and `git_options` top-level options as well as
`wheel_server_url` and `pre_built` flags for variants.

Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran force-pushed the new-resolver-config2 branch from 599609d to 976deff Compare April 13, 2026 14:22
@mergify mergify bot added the ci label Apr 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant