gh-105704: Disallow square brackets ([ and ]) in domain names for parsed URLs#129418
Merged
orsenthil merged 4 commits intopython:mainfrom Jan 31, 2025
Merged
gh-105704: Disallow square brackets ([ and ]) in domain names for parsed URLs#129418orsenthil merged 4 commits intopython:mainfrom
[ and ]) in domain names for parsed URLs#129418orsenthil merged 4 commits intopython:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening this pull request in favor of #111261, as the original author appears to not be responding to reviews. This moves the error to occur during parsing instead of on the
ParseResultproperties.cc @gpshead @orsenthil @pschoen-itsc as reviewers on the previous PR.